RFR(S): 8219650: [Testbug] Fix potential crashes in new test hotspot gtest "test_print_hex_dump"

[Thomas Stüfe]

Oops. Pushed and forgot to change the macro to AIX_ONLY... sorry for that.
Can you live with that or should I make a follow up patch?

On Wed, Mar 6, 2019 at 12:49 PM Thomas Stüfe <thomas.stuefe at gmail.com>
wrote:

>
>
> On Wed, Mar 6, 2019 at 12:44 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
>> On 3/6/19 12:27 PM, Thomas Stüfe wrote:
>> > Okay next try:
>> >
>> >
>> http://cr.openjdk.java.net/~stuefe/webrevs/8219650-shade-print-hex/webrev.01/webrev/
>>
>> Looks okay. Boy, what a ride. Thanks for doing this!
>>
>
> I was feeling guilty since I talked you into this... :)
>
>
>>
>> *) I have no strong opinion about this, but maybe we would universally
>> call that non-zero address?
>> It would probably require more work figuring out different bitness, so
>> this one is also good. Maybe
>> one-line it with AIX_ONLY(...) NOT_AIX(0)?
>>
>>  188   // On AIX, zero page is readable.
>>  189   address unreadable =
>>  190 #ifdef AIX
>>  191     (address) 0xFFFFFFFFFFFF0000ULL;
>>  192 #else
>>  193     (address) 0
>>  194 #endif
>>  195     ;
>>
>>
> Lets keep it AIX specific, otherwise in years from now questions come why
> we did not use 0. Also, I did not feel like checking if that address
> happens to be readable on all platforms. Then, there is 32bit...
>
> But I'll use the AIX_ONLY macro, that is better.
>
> ..Thomas
>
>
>
>> -Aleksey
>>
>>