RFR: JDK-8220344: Build failures when using --with-jvm-features=-g1gc, -jfr
Ao Qi
aoqi at loongson.cn
Sat Mar 9 08:56:33 UTC 2019
Hi,
Could someone help to push this fix?
Thanks,
Ao Qi
On Fri, Mar 8, 2019 at 7:39 PM Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>
> Hi,
>
> On Fri, 2019-03-08 at 19:09 +0800, Ao Qi wrote:
> > Hi,
> >
> > I found build is broken when configure with
> > --with-jvm-features=-g1gc,-jfr. There are two problems:
> >
> > 1. g1BarrierSet.hpp is included when g1 is disabled. I think this
> > include can be removed.
> > 2. cardTable.hpp is included in g1CardTable.hpp, and when ifndef
> > INCLUDE_G1GC, cardTable.hpp is missed.
>
> (I noticed that too just yesterday when working on another change -
> thanks for fixing this).
>
> >
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8220344
> >
> > Webrev:
> > http://cr.openjdk.java.net/~aoqi/8220344/webrev.00/
> >
> >
>
> looks good to me.
>
> Thomas
>
More information about the hotspot-dev
mailing list