RFR: 8217576: C1 atomic access handlers use incorrect decorators

David Holmes david.holmes at oracle.com
Mon Mar 11 07:22:49 UTC 2019


Hi Kim,

On 10/03/2019 7:47 am, Kim Barrett wrote:
> Please review this fix of decorator defaulting in C1 atomic access
> generators.  As noted in the bug, C1 presently ignores the decorators
> and only generates fully barriered operations, so the incorrect
> decorators haven't been affecting code generation.

So by fixing this and potentially using weaker memory ordering we could 
infact expose hitherto hidden bugs. :) Okay.

The fix itself looks good.

Thanks,
David
-----

> CR:
> https://bugs.openjdk.java.net/browse/JDK-8217576
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8217576/open.00/
> 
> Testing:
> mach5 tier1.
> 


More information about the hotspot-dev mailing list