RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64

[David Holmes]

On 7/03/2019 3:13 am, Baesken, Matthias wrote:
> Hello ,  could I push the  latest version of   8219241  ?

Sorry based on your earlier email I thought you were looking at doing 
the restructuring. I was then on vacation most of last week.

> A  change that moves the coding more into  platform/cpu  - specific   coding  (if this is wanted)
>   could be  done when bringing in  the AIX  virtualization related info  in another patch  which I plan to do .

If that is imminent then okay - I don't like the code as it is.

Thanks,
David

> Thanks, Matthias
> 
> 
>> -----Original Message-----
>> From: Baesken, Matthias
>> Sent: Freitag, 1. März 2019 09:09
>> To: 'David Holmes' <david.holmes at oracle.com>; 'hotspot-
>> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>> Subject: RE: RFR: 8219241: Provide basic virtualization related info in the
>> hs_error file on linux/windows x86_64
>>
>> Hi David ,
>>
>> I think a clean way would be to have
>>
>> os::print_virtualization_info(outputStream* st)
>>
>> with  platform and/or if needed platform/cpu  - specific   coding  at the right
>> places .
>>
>> I suggested something similar back then .
>>
>> This would be also  a useful structure  to bring in  the AIX  virtualization
>> related info output .
>>
>>
>> Regards, Matthias
>>
>>
>>> -----Original Message-----
>>> From: David Holmes <david.holmes at oracle.com>
>>> Sent: Donnerstag, 28. Februar 2019 22:49
>>> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
>>> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>>> Subject: Re: RFR: 8219241: Provide basic virtualization related info in the
>>> hs_error file on linux/windows x86_64
>>>
>>> Hi Matthias,
>>>
>>> Combining this with 8219746 I have to insist that we use a nice clean
>>> OS-CPU abstraction for dealing with this and get rid of the platform
>>> ifdefs in os::Linux::print_virtualization_info. What you've added in
>>> VM_Version would seem to be the right kind of platform specific
>>> functionality and it seems to me that you could get rid of
>>> os::Linux::print_virtualization_info and just use
>>> VM_Version::print_detected_virtualization in its place.
>>>
>>> Thanks,
>>> David
>>>
>>> On 1/03/2019 2:04 am, Baesken, Matthias wrote:
>>>> Hello,   I provided  a second version .
>>>> The  x86_64  assembler code was simplified (thanks to Martin for the
>> hint)  ;
>>> additionally some comments were  adjusted .
>>>>
>>>>
>>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.2/
>>>>
>>>>
>>>> Best regards , Matthias
>>>>
>>>>
>>>>
>>>> Hello , please review the following change.
>>>> It provides basic virtualization related information in the hs_error file on
>>> linux/windows x86_64.
>>>> We use cpuid  to get the information (detection of VMWare, Xen, KVM
>> and
>>> HyperV is included).
>>>>
>>>> Some info about how to detect the virtualization info can be found here :
>>>> https://kb.vmware.com/s/article/1009458
>>>>
>>>>
>>>>
>>>> (it is VMware related but can be applied for other virtualization
>>> technologies as well)
>>>>
>>>>
>>>> An overview of the ID strings can be found here as well :
>>>>
>>>> https://en.wikipedia.org/wiki/CPUID
>>>> The following are known ID strings from virtual machines: ...
>>>>
>>>>
>>>>
>>>> bug/webrev :
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8219241
>>>>
>>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.1/
>>>>
>>>>
>>>>
>>>> Thanks, Matthias
>>>>