[13] RFR(S): 8220341: Class redefinition fails with assert(!is_unloaded()) failed: unloaded method on the stack

[coleen.phillimore at oracle.com]

Looks good, with a reminder not to touch the method and hot_method if 
the entry in the compile queue is unloaded because they may be deleted 
if they are old (ie. redefined) Methods.

Thanks,
Coleen


On 3/11/19 4:55 AM, Tobias Hartmann wrote:
> Thanks Erik.
>
> Best regards,
> Tobias
>
> On 11.03.19 09:54, Erik Österlund wrote:
>> Hi Tobias,
>>
>> Looks good.
>>
>> Thanks,
>> /Erik
>>
>> On 2019-03-08 15:16, Tobias Hartmann wrote:
>>> [Switching to hotspot-dev]
>>>
>>> On 08.03.19 14:34, Tobias Hartmann wrote:
>>>> Hi,
>>>>
>>>> please review the following patch:
>>>> https://bugs.openjdk.java.net/browse/JDK-8220341
>>>> http://cr.openjdk.java.net/~thartmann/8220341/webrev.00/
>>>>
>>>> The assert added by 8163511 [1] is wrong and should be replaced by a check because class
>>>> redefinition can encounter unloaded methods in the compile queue during marking (they will be
>>>> removed from the queue later).
>>>>
>>>> Verified fix with failing tests at hs-tier6. Will run more tests.
>>>>
>>>> Thanks,
>>>> Tobias
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8163511
>>>>