RFR: 8218975: Bug in macOSX kernel's pthread support

[Thomas Schatzl]

Hi,

On Fri, 2019-03-15 at 19:03 -0400, Kim Barrett wrote:
> Please review this fix for intermittent Mac-only crashes involving
> the OWSTTaskTerminator.
> 
> This is joint work with Patricio Chilano Mateo. 
> [...]

Thanks for the hard work on this!

> CR:
> https://bugs.openjdk.java.net/browse/JDK-8218975
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8218975/open.01/
> 
> Testing:
> mach5 tier1-5
> mach5 the specific test, 2000 times with no failures.  Without this
>   change, typical failure rate seems to be on the order of 0.5-1.0%.
> Performance testing on Mac found no regressions.
> 

  looks good, with one note:

Afaik the getters for particular member variable are (at least in gc
code) typically not postfixed at all, or at most with "_addr", and
definitely not with "_ptr".
The "_ptr" suffix just feels odd as it is really never used elsewhere
in similar cases (in gc code only?).

I let you decide whether it is appropriate to do any renaming. There is
no need for a re-review from me for either decision.
If this were GC code I would probably be a bit more insistent on not
having a "_ptr" suffix.

Thanks,
  Thomas