RFR [XS] : 8220781: linux-s390 : os::get_summary_cpu_info gives bad output

[David Holmes]

Hi Matthias,

On 19/03/2019 1:41 am, Baesken, Matthias wrote:
> Hello,  please review the following small fix.
> Issue :  currently  the  Host:    information line in the hs_err file  looks strange  on  linux s390x .
> Here is an example :
> 
> Host: s    : 6, 6 cores, 11G, SUSE Linux Enterprise Server 11 (s390x)
> 
> The strange  output  after Host:    ("s    : 6")    is caused  by  os::get_summary_cpu_info  ; it scans for the string "processor"   and runs into    the second line   of the  file :
> 
> more /proc/cpuinfo
> vendor_id       : IBM/S390
> # processors    : 6
> 
> This leads to  "s    : 6" .
> Instead  we can get   the  "machine"  ID -number  which is available  in the  /proc/cpuinfo   file . This can be used to look up the machine+related processor model .

That seems fine. You're in a better position to assess the correctness 
of this.

> Another question  I had when looking into the   issue   -  why is the  hostname  after "Host:"    only printed in the non-product case ?
> It could be also helpful  in the product build as well .

The host name is considered "sensitive" information so is not exposed in 
product builds. It's provided in non-product builds to aid in test 
failure diagnosis.

Thanks,
David

> 
> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8220781
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8220781.0/
> 
> 
> 
> Thanks, Matthias
> 
>