Unused member field/dead code in hotspot/logging/log.hpp?

[Srinivas Ramakrishna]

Thanks for the prompt response/confirmation/ifnormation, David!

-- ramki

On Mon, Mar 18, 2019 at 5:16 PM David Holmes <david.holmes at oracle.com>
wrote:

> Hi Ramki,
>
> On 19/03/2019 9:37 am, Srinivas Ramakrishna wrote:
> > Hello all,
> >
> > I was making some modifications to unified logging for optionally making
> it
> > async -- basically porting some of our JDK 8
> > code changes over to OpenJDK 11's Unified Logging framework, and I
> noticed
> > that in log.hpp there appears to be an unused
> > static member in class LogImpl:
> >
> > class LogImpl {
> >   private:
> >    static const size_t LogBufferSize = 512;
> >
> > It doesn't seem to be used anywhere, at least in the OpenJDK 11 vintage I
> > am looking at.
> >
> > Is it used elsewhere in code not visible in OpenJDK, or can it be
> deleted?
>
> Looks dead to me. Hard to track if it may have been used in the past.
>
> > (PS: please let me know if this question shd go to some other more
> specific
> > email list.)
>
> hotspot-runtime-dev would probably be more specific, but hotspot-dev is
> fine.
>
> Cheers,
> David
>
> > thanks,
> > -- ramki
> >     // TwitterVMTeam // openjdk: ysr
> >
>