Unused member field/dead code in hotspot/logging/log.hpp?

[Srinivas Ramakrishna]

Ah, nice, thanks!

On Tue, Mar 19, 2019 at 12:56 AM Stefan Karlsson <stefan.karlsson at oracle.com>
wrote:

> Hi Ramki,
>
> Searching for LogBufferSize in the output of:
>   hg log --follow -p src/hotspot/share/logging/log.hpp
>
> shows that its usage was removed in:
>   changeset:   37247:bdbfe42632cb
>   user:        rehn
>   date:        Mon Apr 04 15:05:52 2016 +0200
>   summary:     8153254: Delegate (v)write from Log to LogTagSet
>
> You could also use hg grep, but I think that often takes longer time to
> perform:
> hg grep --all --follow "LogBufferSize" src/hotspot/share/logging/log.hpp
> src/hotspot/share/logging/log.hpp:47216:+:  static const size_t
> LogBufferSize = 512;
> hotspot/src/share/vm/logging/log.hpp:37247:-:    char buf[LogBufferSize];
> hotspot/src/share/vm/logging/log.hpp:33097:+:  static const size_t
> LogBufferSize = 512;
> hotspot/src/share/vm/logging/log.hpp:33097:+:    char buf[LogBufferSize];
>
> Cheers,
> StefanK
>
> On 2019-03-19 00:37, Srinivas Ramakrishna wrote:
> > Hello all,
> >
> > I was making some modifications to unified logging for optionally making
> it
> > async -- basically porting some of our JDK 8
> > code changes over to OpenJDK 11's Unified Logging framework, and I
> noticed
> > that in log.hpp there appears to be an unused
> > static member in class LogImpl:
> >
> > class LogImpl {
> >   private:
> >    static const size_t LogBufferSize = 512;
> >
> > It doesn't seem to be used anywhere, at least in the OpenJDK 11 vintage I
> > am looking at.
> >
> > Is it used elsewhere in code not visible in OpenJDK, or can it be
> deleted?
> >
> > (PS: please let me know if this question shd go to some other more
> specific
> > email list.)
> >
> > thanks,
> > -- ramki
> >     // TwitterVMTeam // openjdk: ysr
> >
>