RFR 8157372: C2: Node::cmp() should return bool

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Mar 19 20:38:58 UTC 2019


Hi Derek,

On 3/19/19 11:08 AM, Derek Thomson wrote:
> Changed uint to bool throughout. Could someone review my change please?

Looks good to me.

> Also, what tests should I run to validate this?

You can use submit repo to do build and tier1 testing on all platforms supported by Oracle:
https://wiki.openjdk.java.net/display/Build/Submit+Repo

> 
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8157372/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8157372
> 

Thanks,
Vladimir


More information about the hotspot-dev mailing list