RFR 8157372: C2: Node::cmp() should return bool

[Derek Thomson]

Thanks Vladimir - is there a process for asking for a second reviewer?

On Mon, Mar 25, 2019 at 11:55 AM Vladimir Kozlov <vladimir.kozlov at oracle.com>
wrote:

> Good.
>
> I think you need second review to make sure nothing is missing. Note, I
> thought to suggest to fix Type::cmp() too but
> that is more complicated and outside this RFE.
>
> After reviews you need sponsor to push (person with Committer privilege).
>
> Thanks,
> Vladimir
>
> On 3/25/19 11:10 AM, Derek Thomson wrote:
> > Okay, JC ran the tests, with the following result:
> >
> > Job: mach5-one-jcbeyler-JDK-8157372-2-20190323-1437-1389995
> > BuildId: 2019-03-23-1433293.jcbeyler.source
> > No failed tests
> > Tasks Summary
> > NA: 0
> > EXECUTED_WITH_FAILURE: 0
> > HARNESS_ERROR: 0
> > FAILED: 0
> > UNABLE_TO_RUN: 0
> > KILLED: 0
> > NOTHING_TO_RUN: 0
> > PASSED: 76
> >
> >
> > On Wed, Mar 20, 2019 at 9:39 AM Derek Thomson <dthomson at google.com>
> wrote:
> >
> >> I figured, I'll bug him to run the tests then as I suspect you'll need
> >> Committer privileges. Thanks again, that saves me a lot of time trying
> to
> >> make this work.
> >>
> >> On Wed, Mar 20, 2019 at 9:37 AM Aleksey Shipilev <shade at redhat.com>
> wrote:
> >>
> >>> On 3/20/19 5:33 PM, Derek Thomson wrote:
> >>>> Thanks Aleksey - does this mean I need a userid? I don't have one.
> I've
> >>> been following this guide
> >>>> and can't find any mention of how to do that (or anywhere else):
> >>>> https://openjdk.java.net/contribute/ If I need it, can I get one?
> >>>
> >>> Yes, you need OpenJDK id (and maybe Committer privileges, not sure). JC
> >>> certainly has it, you can
> >>> ask him: http://openjdk.java.net/census#jcbeyler
> >>>
> >>> -Aleksey
> >>>
> >>>
>