RFR(XXS): 8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected"

Volker Simonis volker.simonis at gmail.com
Tue Mar 26 17:52:40 UTC 2019


Thanks Vladimir and Martin.

I've pushed the fix.

On Tue, Mar 26, 2019 at 6:43 PM Doerr, Martin <martin.doerr at sap.com> wrote:
>
> Hi Volker,
>
> I had already thought about that while reviewing the original change. But then I thought it wouldn't be needed because Serial should be always available. I was not aware of the problem when explicitly setting another GC.
>
> Looks good.
>
> Thanks,
> Martin
>
>
> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of Volker Simonis
> Sent: Dienstag, 26. März 2019 18:24
> To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> Cc: Vladimir Kozlov <vladimir.kozlov at oracle.com>
> Subject: RFR(XXS): 8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected"
>
> Hi,
>
> sorry, but I broke tier 3 suite with my test from "8221083 [ppc64]
> Wrong oop compare in C1-generated code". The fix is trivial:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2019/8221483/
> https://bugs.openjdk.java.net/browse/JDK-8221483
>
> Because the test is only meaningful if run with SerialGC it uses
> "main/othervm" mode with "-XX:+UseSerialGC" as command line option.
> However this may break if JTreg is called with another, explicit GC
> setting in "vmoptions" (what the tier3 tests are apparently doing).
>
> Adding "@requires vm.gc.Serial" will only run the test if no explicit
> GC was set outside of the test or if the GC was explicitly set to
> "UseSerial".
>
> Thanks,
> Volker


More information about the hotspot-dev mailing list