RFR (S): 8222534: VerifyBeforeExit is not honored when System.exit is called

[David Holmes]

Updated webrev:

http://cr.openjdk.java.net/~dholmes/8222534/webrev.v2/

The XML xtty logging has been removed as it could potentially lead to 
assertion failures too, as well as lengthy pauses in some cases. See 
details in the bug report.

So only the changes to vmOperations.cpp remain and are unchanged from 
v1. (So I'm still claiming Robbin's review :) ).

Thanks,
David

On 30/04/2019 10:52 pm, David Holmes wrote:
> Testing has shown some problems with the XML logging. I think I see the 
> problem - an assert that shouldn't have been copied across - but now I 
> have to understand the implications of having the assertion fail <sigh>
> 
> David
> 
> On 30/04/2019 8:45 pm, David Holmes wrote:
>> Hi Dean,
>>
>> Thanks for taking a look at this.
>>
>> On 30/04/2019 5:07 pm, dean.long at oracle.com wrote:
>>> On 4/29/19 8:54 PM, David Holmes wrote:
>>>> The IdealGraphPrinter::cleanup was deemed unnecessary due to the 
>>>> fact the process is being blown away anyway. 
>>>
>>> It looks like, without it, tail(TOP_ELEMENT) won't be called to end 
>>> the XML output.
>>
>> Good catch! Unfortunately adding the cleanup call resulted in a crash, 
>> as it seems another thread can be in the middle of outputting an XML 
>> element when we hit the terminal safepoint and try to issue the final 
>> XML element:
>>
>> #  Internal Error 
>> (open/src/hotspot/share/utilities/xmlstream.cpp:184), pid=32637, 
>> tid=32644
>> #  assert((!inside_attrs()) || VMError::is_error_reported()) failed: 
>> cannot close element inside attrs
>> #
>>
>> I can't see any reason this would be specific to the System.exit case, 
>> and a fix is beyond the scope of this current bug, so I'll file a new 
>> bug for this so the compiler team can investigate and fix as needed.
>>
>> Thanks,
>> David
>>
>>> dl