8222720: Provide extended VMWare/vSphere virtualization related info in the hs_error file on linux/windows x86_64

Wed May 8 14:46:56 UTC 2019

Hi Robbin,   I'll try to use os::dll_load  .

At a lot of  places  in  HS  dlopen is   used ,   seems  os::dll_load   is not so popular .
Usually  the function is called  with a  

char ebuf[1024];

as the second argument .
Would this really work  for all file systems (with very long paths) I wonder ?

Best regards, Matthias

> 
> Is there a problem with using os::dll_load ?
> 
> Since we have these things for other proprietary hosts I guess this is fine
> also. Code seems okay, except above.
> 
> Thanks, Robbin
> 
> On 2019-05-08 14:57, Baesken, Matthias wrote:
> > Ping  - any reviews / opinions ?
> >
> > Best regards, Matthias
> >
> >
> >
> >> -----Original Message-----
> >> From: Baesken, Matthias
> >> Sent: Dienstag, 30. April 2019 09:23
> >> To: Robbin Ehn <robbin.ehn at oracle.com>; 'hotspot-
> dev at openjdk.java.net'
> >> <hotspot-dev at openjdk.java.net>
> >> Subject: RE: 8222720: Provide extended VMWare/vSphere virtualization
> >> related info in the hs_error file on linux/windows x86_64
> >>
> >> Hello  Robbin,  some of the info is  indeed already available on the guest
> (e.g.
> >> processorMHz ).
> >> Some of the info is  about the host so we do not have it   currently .
> >>
> >>
> >> This is what the   vsphere-guest-ha-monitoring-sdk-65-programming-
> >> guide.pdf    has to say about the metrics info :
> >>
> >> Host - metrics :   "information about the current hypervisor and hardware
> the
> >> virtual machine is running on"
> >> Description about the  different info parts :
> >>
> >> host.cpu.processorMHz – nominal processor speed. Other metrics, such
> as
> >> vm.cpu.used below, are normalized to this speed.
> >>   host.cpu.coresPerPkg – actual cores per socket, not including
> hyperthreads.
> >> Useful for determining cache effects and other aspects of socket sharing.
> >>                                              Information is also available with CPUID instruction.
> >> Note that vSphere does not implement virtual hyperthreads.
> >> host.cpu.packages – number of CPU sockets on the host (non-default).
> >> host.cpu.cores – number of cores on the host across all sockets, not
> including
> >> hyperthreads (non-default).
> >> host.cpu.threads – number of logical CPUs on the host across all sockets,
> >> including hyperthreads (non-default).
> >> host.dmi.product – “product” field in the host SMBIOS data (non-default).
> >> host.dmi.vendor – “vendor” field in the host SMBIOS data (non-default).
> >>
> >> ( so the  host.dmi  product/vendor   info might not be available depending
> on
> >> the VMWare configuration )
> >>
> >>
> >> Best regards, Matthias
> >>
> >>
> >>> -----Original Message-----
> >>> From: Robbin Ehn <robbin.ehn at oracle.com>
> >>> Sent: Dienstag, 30. April 2019 09:04
> >>> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> >>> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> >>> Subject: Re: 8222720: Provide extended VMWare/vSphere virtualization
> >>> related info in the hs_error file on linux/windows x86_64
> >>>
> >>> Hi Matthias,
> >>>
> >>> If the guest env. we are running in have correct values, what can the
> host
> >>> values be used for in a hs_err context?
> >>>
> >>> Thanks, Robbin
> >>>
> >>> On 2019-04-29 13:02, Baesken, Matthias wrote:
> >>>> Hello,
> >>>>      please review the following enhancement to the VMWare/vSphere
> >>> virtualization related info in the hs_error file on linux/windows x86_64 .
> >>>>
> >>>> In case the guest library from VMWare SDK 6.0 (or higher) is present
> >>> (libvmGuestLib)  or the open-vm-tools guest library is present
> >>>> (libguestlib), we add the host and  initial and current  resource related
> >>> metrics information to the hs_err file .
> >>>> The resource info  (current and first) is taken twice to see diffs over the
> >> VM
> >>> runtime.
> >>>>
> >>>> Example output for host and resource information :
> >>>> host:
> >>>> ------
> >>>> host.cpu.processorMHz = 2194
> >>>> host.cpu.coresPerPkg = 10
> >>>> host.cpu.packages = 4
> >>>> host.cpu.cores = 40
> >>>> host.cpu.threads = 80
> >>>> host.dmi.product = UCSC-C460-M4
> >>>> host.dmi.vendor = Cisco Systems Inc
> >>>>
> >>>> resource:
> >>>> ----------
> >>>> vm.cpu.reserved = 0
> >>>> vm.cpu.limit = -1
> >>>> vm.cpu.used = 2290006442390
> >>>> vm.cpu.contention.cpu = 1436489771
> >>>> vm.cpu.contention.mem = 0
> >>>> vm.numa.local = 16775168
> >>>> vm.numa.remote = 0
> >>>> guest.mem.reserved = 0
> >>>> guest.mem.limit = 3221225456
> >>>> guest.mem.mapped = 16775168
> >>>> guest.mem.consumed = 16699172
> >>>> guest.mem.swapped = 0
> >>>> guest.mem.ballooned = 0
> >>>> guest.mem.swapIn = 0
> >>>> guest.mem.swapOut = 0
> >>>> ovhd.mem.swapped = 0
> >>>> ovhd.mem.swapIn = 0
> >>>> ovhd.mem.swapOut = 0
> >>>>
> >>>>
> >>>> (details on the metrics meaning can be found in the VMWare SDK
> >>> programming guide
> >>>>
> >>>> https://code.vmware.com/docs/6629/guest-and-ha-application-
> >>> monitoring-sdk-programming-guide/
> >>>>
> >>>> see the subsections of "Tools for Extended Guest Statistics" )
> >>>>
> >>>>
> >>>> bug/webrev :
> >>>>
> >>>> https://bugs.openjdk.java.net/browse/JDK-8222720
> >>>>
> >>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8222720.1/
> >>>>
> >>>>
> >>>> Thanks, Matthias
> >>>>