RFR: 8223438: add VirtualizationInformation JFR event

Erik Gahlin erik.gahlin at oracle.com
Wed May 8 16:54:34 UTC 2019


Hello,

Looks good, but do we really need to allocate the name every time an 
event is emitted in jfrPeriodic.cpp?

It will not matter much from a performance perspective, but the code 
would look cleaner if we would have.

EventVirtualizationInformation event;
event.set_name(JfrOSInterface::virtualization_name());
event.commit();

Thanks
Erik


> Hello, please review the following change .
>
> It adds  a  simple VirtualizationInformation   event  to JFR .
>
> The addition  to JFR has been previously  proposed by Erik  when  we 
> discussed the enhancement of hs_error file output  with virtualization 
> related information .
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8223438
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8223438.1/ 
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8223438.1/>
>
> Thanks, Matthias
>



More information about the hotspot-dev mailing list