RFR: 8223136: Move compressed oops functions to CompressedOops class
Stefan Karlsson
stefan.karlsson at oracle.com
Thu May 9 10:03:15 UTC 2019
Thanks, Leo!
I'll fix this changes, run through testing, and then push this.
Thanks,
StefanK
On 2019-05-09 10:58, Leo Korinth wrote:
> Hi Stefan.
>
> Really nice cleanup. Smaller Universe and the code reads much better.
>
> [src/hotspot/share/code/oopRecorder.inline.hpp]
> lacks include guards.
>
> [src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp]
> [src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp]
> fix #include order.
>
>
> src/hotspot/share/compiler/oopMap.cpp
> - // equal to Universe::narrow_oop_base when a narrow oop
> + // equal to CompressedOops::base(() when a narrow oop
> (extra start parenthesis in comment)
>
> Change looks great and no new webrev is needed for me.
>
> Thanks,
> Leo
>
>
> On 07/05/2019 21:28, Stefan Karlsson wrote:
>> These are the latest patches (on jdk/jdk @ 61049e91eae5):
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/01.compressed/
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/02.verifyOption/
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/03.isGCActiveMark/
>>
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/04.oopRecorder/
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/05.memAllocator/
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/06.oopFactory/
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/07.fixIncludes/
>> http://cr.openjdk.java.net/~stefank/8223136/webrev.04/all/
>>
>> I folded the oopsHierarchy change below into the fixIncludes patch. I
>> also found that I hadn't updated all ppc files, so that's fixed as well.
>>
>> This compiles locally on Linux x64. I'll also test that it still works
>> on the platforms we build on.
>>
>> Thanks,
>> StefanK
>
More information about the hotspot-dev
mailing list