RFR (T) 8223675: arm32 build failure after 8223136 (Move compressed oops functions to CompressedOops class

David Holmes david.holmes at oracle.com
Fri May 10 07:39:44 UTC 2019


Hi Aleksey,

I'm a bit perplexed as to how 8223136 caused this as it didn't remove 
any includes of universe.hpp from anywhere ???

But if it fixes it then LGTM.

Cheers,
David

On 10/05/2019 4:45 pm, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223675
> 
> Please review the trivial build fix:
> 
> diff -r f1a8b2447250 src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp
> --- a/src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp  Fri May 10 08:40:10 2019 +0200
> +++ b/src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp  Fri May 10 08:45:18 2019 +0200
> @@ -30,4 +30,5 @@
>   #include "c1/c1_MacroAssembler.hpp"
>   #include "c1/c1_Runtime1.hpp"
> +#include "memory/universe.hpp"
>   #include "nativeInst_arm.hpp"
>   #include "runtime/sharedRuntime.hpp"
> diff -r f1a8b2447250 src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp
> --- a/src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp       Fri May 10 08:40:10 2019 +0200
> +++ b/src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp       Fri May 10 08:45:18 2019 +0200
> @@ -35,4 +35,5 @@
>   #include "gc/shared/cardTableBarrierSet.hpp"
>   #include "gc/shared/collectedHeap.hpp"
> +#include "memory/universe.hpp"
>   #include "nativeInst_arm.hpp"
>   #include "oops/objArrayKlass.hpp"
> diff -r f1a8b2447250 src/hotspot/os_cpu/linux_arm/thread_linux_arm.cpp
> --- a/src/hotspot/os_cpu/linux_arm/thread_linux_arm.cpp Fri May 10 08:40:10 2019 +0200
> +++ b/src/hotspot/os_cpu/linux_arm/thread_linux_arm.cpp Fri May 10 08:45:18 2019 +0200
> @@ -29,4 +29,5 @@
>   #include "gc/shared/collectedHeap.hpp"
>   #include "memory/metaspaceShared.hpp"
> +#include "memory/universe.hpp"
>   #include "runtime/frame.inline.hpp"
> 
> Testing: Linux arm32 cross-compilation build
> 


More information about the hotspot-dev mailing list