RFR [XS] : 8223574: add more thread-related system settings info to hs_error file on AIX

[Doerr, Martin]

Hi Matthias,

yes. Looks good.

Best regards,
Martin


-----Original Message-----
From: Baesken, Matthias 
Sent: Freitag, 10. Mai 2019 12:15
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Cc: Doerr, Martin <martin.doerr at sap.com>
Subject: RE: RFR [XS] : 8223574: add more thread-related system settings info to hs_error file on AIX


Hello, Martin pointed out the same to me , here is the updated webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8223574.1/


Martin, my I add you as reviewer too ?

Thanks ,Matthias


> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Freitag, 10. Mai 2019 08:47
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR [XS] : 8223574: add more thread-related system settings info
> to hs_error file on AIX
> 
> Hi Matthias,
> 
> Thanks for doing this change, I think the information will help
> to analyze out-of-threads situations.
> 
> Why do you use three calls to print this one line?
> I would prefer a single call to st->print_cr().
> Eventually you could change the "load average" code similarly.
> 
> After pushing, could you please update the bug with what
> new printout you added and a short explanation of it's
> meaning/purpose?
> 
> Don't' need to see a new webrev.
> 
> Thanks and best regards,
>   Goetz.
> 
> > -----Original Message-----
> > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf
> Of
> > Baesken, Matthias
> > Sent: Wednesday, May 8, 2019 4:24 PM
> > To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: RFR [XS] : 8223574: add more thread-related system settings info
> to
> > hs_error file on AIX
> >
> > Hello , please review  this small AIX related change .
> > It adds  to the hs_error  file  on AIX  the    maximum number of threads
> within
> > a process.
> >
> > (  The previous  change
> >
> > https://bugs.openjdk.java.net/browse/JDK-8204598
> >
> > added  already  more thread-related system settings info to the hs_error
> file
> > on Linux.
> > On AIX I want to enhance the output too .  )
> >
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8223574
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8223574.0/
> >
> >
> >
> > Thanks, Matthias