RFR (XS) 8223637: PPC64 and S390X build failures after 8223136 (Move compressed oops functions to CompressedOops class)

[John Paul Adrian Glaubitz]

Hi!

On 5/10/19 10:27 AM, Aleksey Shipilev wrote:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8223637
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8223637/webrev.01/

This affects linux-sparc (native Hotspot), too. Applying a similar
fix doesn't work so far:

glaubitz at gcc202:~/jdk$ hg diff
diff -r 45bbef01a6ae src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp
--- a/src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp   Fri May 10 09:56:20 2019 +0200
+++ b/src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp   Fri May 10 13:59:13 2019 +0300
@@ -34,7 +34,9 @@
 #include "gc/shared/barrierSet.hpp"
 #include "gc/shared/cardTableBarrierSet.hpp"
 #include "gc/shared/collectedHeap.hpp"
+#include "memory/universe.hpp"
 #include "nativeInst_sparc.hpp"
+#include "oops/compressedOops.hpp"
 #include "oops/objArrayKlass.hpp"
 #include "runtime/frame.inline.hpp"
 #include "runtime/interfaceSupport.inline.hpp"
diff -r 45bbef01a6ae src/hotspot/cpu/sparc/macroAssembler_sparc.inline.hpp
--- a/src/hotspot/cpu/sparc/macroAssembler_sparc.inline.hpp     Fri May 10 09:56:20 2019 +0200
+++ b/src/hotspot/cpu/sparc/macroAssembler_sparc.inline.hpp     Fri May 10 13:59:13 2019 +0300
@@ -28,6 +28,7 @@
 #include "asm/assembler.inline.hpp"
 #include "asm/macroAssembler.hpp"
 #include "asm/codeBuffer.hpp"
+#include "oops/compressedOops.hpp"
 #include "code/codeCache.hpp"

 inline bool Address::is_simm13(int offset) { return Assembler::is_simm13(disp() + offset); }
glaubitz at gcc202:~/jdk$

Still fails with:

=== Output from failing command(s) repeated here ===
/usr/bin/printf "* For target hotspot_variant-server_libjvm_objs_ad_sparc.o:\n" 
* For target hotspot_variant-server_libjvm_objs_ad_sparc.o:
(/bin/grep -v -e "^Note: including file:" <  /home/glaubitz/jdk/build/linux-sparcv9-server-release/make-support/failure-logs/hotspot_variant-server_libjvm_objs_ad_sparc.o.log || true) | /usr/bin/head -n 12 
In file included from ad_sparc.cpp:29:
ad_sparc.hpp: In member function ‘virtual int encodeHeapOopNode::ins_avoid_back_to_back() const’:
ad_sparc.hpp:7247:66: error: ‘CompressedOops’ has not been declared
ad_sparc.hpp: In constructor ‘encodeHeapOopNode::encodeHeapOopNode()’:
ad_sparc.hpp:7252:76: error: ‘CompressedOops’ has not been declared
if test `/usr/bin/wc -l < /home/glaubitz/jdk/build/linux-sparcv9-server-release/make-support/failure-logs/hotspot_variant-server_libjvm_objs_ad_sparc.o.log` -gt 12; then /bin/echo "   ... (rest of output omitted)" ; fi 
/usr/bin/printf "\n* All command lines available in /home/glaubitz/jdk/build/linux-sparcv9-server-release/make-support/failure-logs.\n" 

* All command lines available in /home/glaubitz/jdk/build/linux-sparcv9-server-release/make-support/failure-logs.
/usr/bin/printf "=== End of repeated output ===\n"  
=== End of repeated output ===

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913