RFR (XS) 8223637: PPC64 and S390X build failures after 8223136 (Move compressed oops functions to CompressedOops class)

Stefan Karlsson stefan.karlsson at oracle.com
Fri May 10 15:58:07 UTC 2019


I took all you patches and merged them with my patch:
http://cr.openjdk.java.net/~stefank/8223637/webrev.02/

There were two includes added to the sparc files that I don't see why 
they would be needed. Either they were unnecessarily added, or some 
other file needs the include.

I also created a version that removes those two lines:
http://cr.openjdk.java.net/~stefank/8223637/webrev.03.delta
http://cr.openjdk.java.net/~stefank/8223637/webrev.03

Will run webrev.03 through our testing.

StefanK

On 2019-05-10 17:36, Schmidt, Lutz wrote:
> OK.
> I will try to set aside some time tomorrow to run a few builds and some quick tests, mainly verifying ppc and s390. The rest should be covered by the submit repo. Will post the results as they become available.
> Please note: I'm not a reviewer. We will need someone else to unleash the patch.
> So long,
> Lutz
> 
> On 10.05.19, 17:30, "John Paul Adrian Glaubitz" <glaubitz at physik.fu-berlin.de> wrote:
> 
>      Hi!
>      
>      On 5/10/19 5:13 PM, Schmidt, Lutz wrote:
>      > it would be great if you could create a consolidated patch, based on http://cr.openjdk.java.net/~stefank/8223637/webrev.01/
>      Sure, will do. I won't be able to do it today, but I will do it
>      tomorrow.
>      
>      Adrian
>      
>      --
>       .''`.  John Paul Adrian Glaubitz
>      : :' :  Debian Developer - glaubitz at debian.org
>      `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>        `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>      
> 


More information about the hotspot-dev mailing list