RFR (XS) 8223637: PPC64 and S390X build failures after 8223136 (Move compressed oops functions to CompressedOops class)

Stefan Karlsson stefan.karlsson at oracle.com
Mon May 13 08:21:57 UTC 2019


On 2019-05-11 16:32, John Paul Adrian Glaubitz wrote:
> On 5/11/19 3:41 PM, Stefan Karlsson wrote:
>>> Well, you would be adding #includes for SPARC that aren't necessary.
>>
>> Please, show me exactly what you want to change, with a webrev based on top of the patch in webrev.04.
> This works for me: http://cr.openjdk.java.net/~glaubitz/8223637/webrev.01/

Since you didn't base this patch on top of my patch, I had to go through 
all files to figure out what you changed.

As far as I can see you also removed the universe.hpp include in 
c1_LIRAssembler_sparc.cpp, which uses Universe. This change would force 
me to unnecessarily retest the patch, and I don't want to do that.

The other change I've found is thread_linux_sparc.cpp. I'm OK with that 
change, and it doesn't invalidate my or Lutz's testing.

Patch with which only changes thread_linux_sparc.cpp.
  http://cr.openjdk.java.net/~stefank/8223637/webrev.05.delta/
  http://cr.openjdk.java.net/~stefank/8223637/webrev.05/

StefanK

> 
> Adrian
> 


More information about the hotspot-dev mailing list