RFR (XS) 8223637: PPC64 and S390X build failures after 8223136 (Move compressed oops functions to CompressedOops class)

[Schmidt, Lutz]

Hi, 

on Saturday, I tested AIX with webrev.04, fastdebug and release builds. Both finished ok. Had no chance/time to run tests in excess of java -version. 

Webrev.05 differs from webrev.04 only for linux_sparc/thread_linux_sparc.cpp. I'm pretty sure this will not have any effect on the AIX builds. :-)

We have restarted builds/tests with webrev.05 for some platforms, in particular AIX. We will post results as they become available.

Regards,
Lutz

On 13.05.19, 11:40, "John Paul Adrian Glaubitz" <glaubitz at physik.fu-berlin.de> wrote:

    On 5/13/19 10:21 AM, Stefan Karlsson wrote:
    > On 2019-05-11 16:32, John Paul Adrian Glaubitz wrote:
    > Since you didn't base this patch on top of my patch, I had to go through all files to figure out what you changed.
    
    Ah, you wanted to have a diff against your patch. I misunderstood you then.
    
    > As far as I can see you also removed the universe.hpp include in c1_LIRAssembler_sparc.cpp, which uses Universe. This change would force me to unnecessarily retest the patch, and I don't want to do that.
    
    Which targets does your test include?
    
    As I said before, I can test any Linux target (the s390x is free again)
    and I will be able to test Solaris soonish (need to set up the build
    environment first).
    
    The only thing I can't test is AIX because AIX isn't really available
    to anyone outside the enterprise world.
    
    > The other change I've found is thread_linux_sparc.cpp. I'm OK with that change, and it doesn't invalidate my or Lutz's testing.
    > 
    > Patch with which only changes thread_linux_sparc.cpp.
    >  http://cr.openjdk.java.net/~stefank/8223637/webrev.05.delta/
    >  http://cr.openjdk.java.net/~stefank/8223637/webrev.05/
    
    Works for me on:
    
    - linux-sparc
    - linux-s390x
    - linux-x86_64
    - linux-ppc64el
    - linux-ppc64
    
    Also tested Zero on x86_64, ppc64el and s390x.
    
    Those were release builds.
    
    Adrian
    
    -- 
     .''`.  John Paul Adrian Glaubitz
    : :' :  Debian Developer - glaubitz at debian.org
    `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
      `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913