RFR (XS) 8223637: PPC64 and S390X build failures after 8223136 (Move compressed oops functions to CompressedOops class)

[Stefan Karlsson]

The patch has now been pushed to jdk/jdk:
http://hg.openjdk.java.net/jdk/jdk/rev/1b03400e5a8f

Thanks,
StefanK

On 2019-05-13 21:46, Schmidt, Lutz wrote:
> Hi,
>
> when exactly are you planning to push this change? Are there still any obstacles?
>
> The pure jdk/jdk repo as of 19:33 (UTC) does not yet contain the required fixes for linuxs390x and linuxppc64. I stopped after trying to build those two.
>
> Thanks,
> Lutz
>
>
>
> On 13.05.19, 14:59, "Schmidt, Lutz" <lutz.schmidt at sap.com> wrote:
>
>      Go!
>      
>      Linuxppc, linuxppcle, linuxs390x, linuxx84_64, rs6000_64, sun_64 (Solaris_SPARC), all built as fastdebug and release, all green.
>      
>      Tests still running (will not finish in due time), no anomalies so far.
>      
>      Thanks,
>      Lutz
>      
>      
>      On 13.05.19, 12:08, "Stefan Karlsson" <stefan.karlsson at oracle.com> wrote:
>      
>          On 2019-05-13 11:40, John Paul Adrian Glaubitz wrote:
>          > On 5/13/19 10:21 AM, Stefan Karlsson wrote:
>          >> On 2019-05-11 16:32, John Paul Adrian Glaubitz wrote:
>          >> Since you didn't base this patch on top of my patch, I had to go through all files to figure out what you changed.
>          >
>          > Ah, you wanted to have a diff against your patch. I misunderstood you then.
>          >
>          >> As far as I can see you also removed the universe.hpp include in c1_LIRAssembler_sparc.cpp, which uses Universe. This change would force me to unnecessarily retest the patch, and I don't want to do that.
>          >
>          > Which targets does your test include?
>          >
>          > As I said before, I can test any Linux target (the s390x is free again)
>          > and I will be able to test Solaris soonish (need to set up the build
>          > environment first).
>          
>          Regarding sparc testing, I've tested Solaris Sparcv9 with fastdebug and
>          release.
>          
>          >
>          > The only thing I can't test is AIX because AIX isn't really available
>          > to anyone outside the enterprise world.
>          >
>          >> The other change I've found is thread_linux_sparc.cpp. I'm OK with that change, and it doesn't invalidate my or Lutz's testing.
>          >>
>          >> Patch with which only changes thread_linux_sparc.cpp.
>          >>   http://cr.openjdk.java.net/~stefank/8223637/webrev.05.delta/
>          >>   http://cr.openjdk.java.net/~stefank/8223637/webrev.05/
>          >
>          > Works for me on:
>          >
>          > - linux-sparc
>          > - linux-s390x
>          > - linux-x86_64
>          > - linux-ppc64el
>          > - linux-ppc64
>          >
>          > Also tested Zero on x86_64, ppc64el and s390x.
>          >
>          > Those were release builds.
>          
>          Great. Then we're just waiting for Lutz to say go.
>          
>          Thanks,
>          StefanK
>          
>          >
>          > Adrian
>          >
>          
>      
>      
>