8222720: Provide extended VMWare/vSphere virtualization related info in the hs_error file on linux/windows x86_64

[Baesken, Matthias]

Hi David, thanks for  the review !

Robbin, my I add you as reviewer too ?


Best regards, Matthias



> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Freitag, 10. Mai 2019 15:41
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: Re: 8222720: Provide extended VMWare/vSphere virtualization
> related info in the hs_error file on linux/windows x86_64
> 
> On 10/05/2019 7:08 pm, Baesken, Matthias wrote:
> > Hi  David,   I removed / adjusted the ifdefs and  added checks != NULL :
> >
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8222720.3/
> 
> Looks good.
> 
> >
> > (not sure however about VMWARE Fusion on Mac, have no access to it )
> 
> No idea either.
> 
> Thanks,
> David
> 
> > Regards, Matthias
> >
> >>
> >> Hi Matthias,
> >>
> >> On 10/05/2019 4:21 pm, Baesken, Matthias wrote:
> >>> Hello, here  is an updated  version :
> >>>
> >>> http://cr.openjdk.java.net/~mbaesken/webrevs/8222720.2/
> >>>
> >>> I switched to  os::dll_load  /  os::dll_lookup  .
> >>> Also removed the VMWare related names  ( now  the name is
> >> "VirtualizationSupport"  ).
> >>
> >> Thanks!
> >>
> >> src/hotspot/cpu/x86/vm_version_x86.cpp
> >>
> >> No ifdefs needed.
> >>
> >> src/hotspot/share/utilities/virtualizationSupport.cpp
> >>
> >>    47 #if defined(__linux)
> >>
> >> The common form of this is:
> >>
> >> #ifdef LINUX
> >>
> >>    62   if (GuestLib_StatGet && GuestLib_StatFree) {
> >>
> >> Style nit: avoid implicit booleans - test against NULL.
> >>
> >> ---
> >>
> >> Otherwise seems fine.
> >>
> >> Thanks,
> >> David
> >> -----
> >>
> >>> Best regards, Matthias
> >>>
> >>>
> >>>>
> >>>> Hi David, thanks for the feedback . I'll provide an updated webrev .
> >>>>
> >>>>> **Not sure about the validity of using "vmware" in the name of files
> or
> >>>>> classes either due to its trademark status.
> >>>>
> >>>> Well , we have a lot of  technology  names in file-names (AIX and
> >> Windows
> >>>> come to mind) .
> >>>>
> >>>> But to be on the safe side,  I think I'll  choose a more generic name .
> >>>>
> >>>>
> >>>> Best regards, Matthias
> >>>>
> >>>