[13] RFR(S): 8223885: hs_err and replay file may contain garbage when overwriting existing file

[Tobias Hartmann]

Hi Thomas,

On 16.05.19 07:22, Thomas Stüfe wrote:
> Again, sorry for that.
> 
> I found that CDT (I use Eclipse CDT) call hierarchy was lying to me and did not show the second call
> to prepate_log_file in VMError::report_and_die(), so I missed the fact that this affects compiler
> replay files. I am upset by this, since CDT is my main work tool nowadays.

I've recently switched from Eclipse to CLion which seems to be much better at code analysis and also
shows both usages in the call hierarchy.

> Also confusing is that the submit tests went thru fine. So I guess the replay compiler test is not
> part of the submit test suite.

Yes, unfortunately it's not executed at tier1.

Best regards,
Tobias