RFR (XS) 8224033: os::snprintf should be used in virtualizationSupport.cpp

Aleksey Shipilev shade at redhat.com
Thu May 16 11:49:00 UTC 2019


On 5/16/19 1:44 PM, Baesken, Matthias wrote:
> However ,  with VS2017  the  windows x86_64  build works as well with PCH disabled . So it seems 
> to me that it is not  (only)   a PCH related issue .

Yes, it is. I believe we get the header included transitively with PCH from somewhere. No biggie,
using os::sprintf needs os.hpp, which is already included. My CI builds with old VS 2013, which is
problematic sometimes, but it also finds legit problems like this one.

-Aleksey



More information about the hotspot-dev mailing list