RFR (XS) 8224170: Build failures after JDK-8207812 (Implement Dynamic CDS Archive)

Aleksey Shipilev shade at redhat.com
Sat May 18 16:48:38 UTC 2019


On 5/18/19 6:32 PM, Vladimir Kozlov wrote:
> Good.

Thanks, I am going to push this under triviality rules.

> Should we also fix next line?:
> 
> int diff = int(estimate) - int(used);
> 
> as
> 
> int diff = int(estimate - used);

I think this would be incorrect: size_t underflow if "estimate < used"? I'd rather make such a
change in a in follow up (and well-tested) patch.

-Aleksey



More information about the hotspot-dev mailing list