RFR: 8224201: Simplify JVM flag macro expansions

[Thomas Stüfe]

Hi Stefan,

this is a nice cleanup!

Looks good to my naked eye.

I would probably compare a precompiled globals.cpp from before your patch
and after it and check the diffs.

Non-PCH builds too, as Vladimir suggested. Maybe also with some features
switched off, e.g. jvmci.

If all tests well I do not need another webrev.

Cheers, Thomas

On Mon, May 20, 2019 at 12:56 PM Stefan Karlsson <stefan.karlsson at oracle.com>
wrote:

> Hi all,
>
> Please review this patch to simplify how we generate the different parts
> of the JVM flags code.
>
> https://cr.openjdk.java.net/~stefank/8224201/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8224201
>
> Notable parts of the patch:
> - Introduces a ALL_FLAGS macro, used to expand code for all flags.
> - Uses the ALL_FLAGS where appropriate.
> - Constraints list didn't expand JVMCI flags. Fixed by using ALL_FLAGS.
> - Moved <sub-system>_globals.hpp generated declarations to be expanded
> in globals.hpp.
> - Unified FLAG_MEMBER and FLAG_MEMBER_WITH_TYPE into FLAG_MEMBER_ENUM
> and change names accordingly.
>
> This change makes it easier to do future changes to the JVM flags
> handling code. For example: "JDK-8224203Remove need to specify type when
> using FLAG_SET macros"
>
> Compiled on tier1 platforms.
>
> Thanks,
> StefanK
>
>