RFR: 8224201: Simplify JVM flag macro expansions
Robbin Ehn
robbin.ehn at oracle.com
Tue May 21 08:52:45 UTC 2019
Yes and the follow-up, 8224203!
/Robbin
On 2019-05-21 10:48, Stefan Karlsson wrote:
> Hi Robbin,
>
> Thanks for taking a look at this. Can I consider this reviewed by you?
>
> StefanK
>
> On 2019-05-20 19:53, Robbin Ehn wrote:
>> Hi Stefan,
>>
>> Thanks for fixing!
>>
>> /Robbin
>>
>> On 2019-05-20 12:56, Stefan Karlsson wrote:
>>> Hi all,
>>>
>>> Please review this patch to simplify how we generate the different parts of
>>> the JVM flags code.
>>>
>>> https://cr.openjdk.java.net/~stefank/8224201/webrev.01/
>>> https://bugs.openjdk.java.net/browse/JDK-8224201
>>>
>>> Notable parts of the patch:
>>> - Introduces a ALL_FLAGS macro, used to expand code for all flags.
>>> - Uses the ALL_FLAGS where appropriate.
>>> - Constraints list didn't expand JVMCI flags. Fixed by using ALL_FLAGS.
>>> - Moved <sub-system>_globals.hpp generated declarations to be expanded in
>>> globals.hpp.
>>> - Unified FLAG_MEMBER and FLAG_MEMBER_WITH_TYPE into FLAG_MEMBER_ENUM and
>>> change names accordingly.
>>>
>>> This change makes it easier to do future changes to the JVM flags handling
>>> code. For example: "JDK-8224203Remove need to specify type when using
>>> FLAG_SET macros"
>>>
>>> Compiled on tier1 platforms.
>>>
>>> Thanks,
>>> StefanK
>>>
More information about the hotspot-dev
mailing list