RFR: 8224201: Simplify JVM flag macro expansions

[coleen.phillimore at oracle.com]

I didn't do a full review, but do we still need globals_ext.hpp ?

Can this set of macros for ALL_FLAGS be put in globals_shared.hpp 
also?   It would be nice for globals.hpp to be mostly the flag list 
rather than seeing these macros.

I think we can still build aarch64 and zero locally.

thanks,
Coleen

On 5/21/19 7:05 AM, Stefan Karlsson wrote:
> Thanks for the review, Thomas.
>
> StefanK
>
> On 2019-05-21 12:41, Thomas Schatzl wrote:
>> Hi,
>>
>> On Mon, 2019-05-20 at 12:56 +0200, Stefan Karlsson wrote:
>>> Hi all,
>>>
>>> Please review this patch to simplify how we generate the different
>>> parts of the JVM flags code.
>>>
>>> https://cr.openjdk.java.net/~stefank/8224201/webrev.01/
>>> https://bugs.openjdk.java.net/browse/JDK-8224201
>>>
>>> Notable parts of the patch:
>>> - Introduces a ALL_FLAGS macro, used to expand code for all flags.
>>> - Uses the ALL_FLAGS where appropriate.
>>> - Constraints list didn't expand JVMCI flags. Fixed by using
>>> ALL_FLAGS.
>>> - Moved <sub-system>_globals.hpp generated declarations to be
>>> expanded
>>> in globals.hpp.
>>> - Unified FLAG_MEMBER and FLAG_MEMBER_WITH_TYPE into
>>> FLAG_MEMBER_ENUM
>>> and change names accordingly.
>>>
>>> This change makes it easier to do future changes to the JVM flags
>>> handling code. For example: "JDK-8224203Remove need to specify type
>>> when using FLAG_SET macros"
>>
>>    although I saw that you already have quite a few reviewers after
>> working through it: looks good. Very nice cleanup.
>>
>> Thanks,
>>    Thomas
>>
>>