RFR: 8224201: Simplify JVM flag macro expansions

[gerard ziemski]

Very, very nice.

If you haven't checked in yet (according to the bug you haven't), could 
we bump up the INITIAL_RANGES_SIZE to 512 (to avoid having to grow the 
range list at startup - the list of flags grew beyond the initial size) 
since we're modifying the jvmFlagRangeList.cpp anyhow? (no need for webrev)

Did you run the TestOptionsWithRanges.java test?


cheers

On 5/20/19 5:56 AM, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patch to simplify how we generate the different 
> parts of the JVM flags code.
>
> https://cr.openjdk.java.net/~stefank/8224201/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8224201
>
> Notable parts of the patch:
> - Introduces a ALL_FLAGS macro, used to expand code for all flags.
> - Uses the ALL_FLAGS where appropriate.
> - Constraints list didn't expand JVMCI flags. Fixed by using ALL_FLAGS.
> - Moved <sub-system>_globals.hpp generated declarations to be expanded 
> in globals.hpp.
> - Unified FLAG_MEMBER and FLAG_MEMBER_WITH_TYPE into FLAG_MEMBER_ENUM 
> and change names accordingly.
>
> This change makes it easier to do future changes to the JVM flags 
> handling code. For example: "JDK-8224203Remove need to specify type 
> when using FLAG_SET macros"
>
> Compiled on tier1 platforms.
>
> Thanks,
> StefanK
>
>