RFR: [XS] 8224750: Display thread once in Internal exceptions event log lines

[coleen.phillimore at oracle.com]

+1
Thank you!
Coleen

On 5/28/19 5:55 AM, Baesken, Matthias wrote:
> Thanks Martin !
>
> Is a second  review needed for the XS change, or  1 sufficient because it is XS ?
>
> Best regards, Matthias
>
>
>
>> -----Original Message-----
>> From: Doerr, Martin
>> Sent: Dienstag, 28. Mai 2019 11:02
>> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
>> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>> Subject: RE: RFR: [XS] 8224750: Display thread once in Internal exceptions
>> event log lines
>>
>> Hi Matthias,
>>
>> looks good.
>>
>> Thanks,
>> Martin
>>
>>
>>> -----Original Message-----
>>> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf
>> Of
>>> Baesken, Matthias
>>> Sent: Montag, 27. Mai 2019 10:29
>>> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>>> Subject: RFR: [XS] 8224750: Display thread once in Internal exceptions
>> event
>>> log lines
>>>
>>> Hello, please review this small patch , it  shortens the  internal exceptions
>>> event log entries .
>>>
>>>
>>> Currently the internal exceptions-related event log - part in the hs_err file
>>> looks like this :
>>>
>>> Internal exceptions (20 events):
>>> Event: 9.075 Thread 0x000003ff7c971800 Exception <a .... exception-related
>>> info/signature ....> (0x00000000d930ed40)
>>> thrown [/mydir/jdk/src/hotspot/share/oops/constantPool.cpp, line 777]
>>> for thread 0x000003ff7c971800
>>>
>>>
>>> One can see that the thread is displayed ***twice*** in every line, once at
>>> the beginning :
>>> Event: 9.075 Thread 0x000003ff7c971800
>>>
>>> and again at the end:
>>> for thread 0x000003ff7c971800
>>>
>>> I think the thread- info should be displayed just once (saves a bit space and
>>> makes the output shorter).
>>>
>>> New output example :
>>>
>>> Event: 4.785 Thread 0x000003ff94a57800 Exception <a
>>> 'java/lang/NoSuchFieldError'{0x00000000df139c28}> (0x00000000df139c28)
>>> thrown [/mydir/jdk/src/hotspot/share/prims/jni.cpp, line 598]
>>>
>>>
>>>
>>>
>>> Bug/webrev :
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8224750
>>>
>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8224750.0/
>>>
>>>
>>>
>>> Thanks ,Matthias