RFR(s): 8224600: Provide VM.events command

[David Holmes]

Hi Thomas,

On 24/05/2019 5:51 am, Thomas Stüfe wrote:
> Hi all,
> 
> May I please have reviews for the following addition to jcmd.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224600
> CSR: https://bugs.openjdk.java.net/browse/JDK-8224601
> webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.00/webrev/index.html

This seems quite reasonable but I have a couple of queries/comments:

Where do the short-names of the logs get used? Is that what you ask for 
via the Dcmd? How does the user know what logs are available?


// Print log names (for help output of VM.events

This comment appears in a few places but is missing the final ).

The test should have a single copyright year of 2019.

The test should be checking all the variations to ensure if you ask for 
exceptions you only get exceptions etc.

Is the test guaranteed to see events of all types? In particular class 
unloading may not occur in a short run (and only anonymous classes would 
get unloaded unless custom loaders are involved).

Thanks,
David
-----

> This adds a new command, "VM.events", which can be used to display VM event
> logs. Please see linked CSR for details.
> 
> The CSR itself is not yet approved but already in proposed state.
> 
> Thanks, Thomas
>