RFR (XS) 8225104: 32-bit build failures after JDK-8222252

David Holmes david.holmes at oracle.com
Fri May 31 09:32:12 UTC 2019


On 31/05/2019 6:25 pm, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8225104
> 
> The new UseCompressedOops block has to be protected with _LP64, like all other blocks are. I think
> it is a trivial change, please review.

Why should that be?

./share/runtime/globals.hpp:  lp64_product(bool, UseCompressedOops, 
false,                              \
./share/runtime/globals.hpp:          "lp64_product means flag is always 
constant in 32 bit VM")        \

I don't see any ifdef around its use here:

share/utilities/globalDefinitions.cpp
cpu/x86/templateTable_x86.cpp

??

David
-----

> Fix:
>    http://cr.openjdk.java.net/~shade/8225104/webrev.01/
> 
> Testing: {x86_32, x86_64} builds
> 


More information about the hotspot-dev mailing list