RFR (XS) 8225104: 32-bit build failures after JDK-8222252
Aleksey Shipilev
shade at redhat.com
Fri May 31 15:41:14 UTC 2019
On 5/31/19 3:41 PM, David Holmes wrote:
> On 31/05/2019 7:45 pm, Aleksey Shipilev wrote:
>> I believe the actual failure is down at:
>>
>> 1816 FLAG_SET_ERGO(UseCompressedOops, false);
>> 1817 FLAG_SET_ERGO(UseCompressedClassPointers, false);
>
> Interesting. I would have expected the compiler to ignore the entire block given the condition
> should be a compile-time constant of false.
Yeah, well. I think it does not even parse well when FLAG* is not defined for UseCompressedOops with
x86_32.
>> And while we can protect those specifically, I see arguments.cpp just ifdefs the entire
>> UseCompressedOops blocks in other instances. So, it seems consistent to do the same here.
>
> Okay. Thanks for the additional info.
Thanks, I shall push shortly to unbreak jdk/jdk.
-Aleksey
More information about the hotspot-dev
mailing list