8233328: fix minimal VM build on Linux s390x

[Baesken, Matthias]

Hi Martin, I  changed the  #ifdef   around  the intrinsics  and  moved  the inclusion  in sharedRuntime_s390.cpp  .

May I add  you as a reviewer ?

Best regards , Matthias

From: Doerr, Martin <martin.doerr at sap.com>
Sent: Mittwoch, 6. November 2019 12:44
To: Schmidt, Lutz <lutz.schmidt at sap.com>; Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Subject: RE: 8233328: fix minimal VM build on Linux s390x

Hi Matthias,

> One little thing: you could make array_equals() depend on #ifdef COMPILER2 as well.
> That would save some more bytes.
Please either protect all or no intrinsic implementations with #ifdef COMPILER2 (string_compress to string_indexof_char).

sharedRuntime_s390.cpp:
#include should be sorted alphabetically.

Otherwise looks good to me. Thanks for fixing it.

Best regards,
Martin


From: Schmidt, Lutz <lutz.schmidt at sap.com<mailto:lutz.schmidt at sap.com>>
Sent: Dienstag, 5. November 2019 16:10
To: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>>
Cc: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>
Subject: Re: 8233328: fix minimal VM build on Linux s390x

Hi Matthias,

your change looks even better now. Please note: I’m not a Reviewer.

One little thing: you could make array_equals() depend on #ifdef COMPILER2 as well. That would save some more bytes.

Thanks,
Lutz

From: "Baesken, Matthias" <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Date: Tuesday, 5. November 2019 at 09:54
To: "hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>" <hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>>
Cc: "Doerr, Martin (martin.doerr at sap.com<mailto:martin.doerr at sap.com>)" <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>, Lutz Schmidt <lutz.schmidt at sap.com<mailto:lutz.schmidt at sap.com>>
Subject: RE: RFR: 8233328: fix minimal VM build on Linux s390x

Hello, here is another webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8233328.2/

It  adjusts the coding in macroAssembler_s390.cpp  mentioned below .


Best regards, Matthias


From: Baesken, Matthias
Sent: Montag, 4. November 2019 12:27
To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>>
Subject: RFR: 8233328: fix minimal VM build on Linux s390x

Hello, please  review  the following change that   fixes the “minimal VM”   build  on linuxs390x .

While looking into the issue I noticed that

MacroAssembler::generate_type_profiling

( in http://cr.openjdk.java.net/~mbaesken/webrevs/8233328.1/src/hotspot/cpu/s390/macroAssembler_s390.cpp.frames.html   )

Is ununsed so I removed it (probably it is a left over from  old  jdk8 (?) times ) .

In


2929 void MacroAssembler::nmethod_UEP(Label& ic_miss) {

2930 #ifdef COMPILER2

2931   Register ic_reg       = as_Register(Matcher::inline_cache_reg_encode());

2932 #else

2933   Register ic_reg       = as_Register(0);

2934 #endif

We probably  still need to replace as_Register(0);   with something better , any suggestions ?



Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8233328

http://cr.openjdk.java.net/~mbaesken/webrevs/8233328.1/


Thanks, Matthias