RFR(M): 8233787: Break cycle in vm_version* includes
Schmidt, Lutz
lutz.schmidt at sap.com
Fri Nov 15 23:51:20 UTC 2019
Thanks, Kim,
for all the useful hints and for the Review.
Regards,
Lutz
On 16.11.19, 00:00, "Kim Barrett" <kim.barrett at oracle.com> wrote:
> On Nov 15, 2019, at 7:19 AM, Schmidt, Lutz <lutz.schmidt at sap.com> wrote:
>
> Hi Kim,
>
> thanks for reviewing - I understand your comments that way. One more review to go. :-)
>
> I made abstract_vm_version.cpp #include vm_version.hpp, and I updated the copyrights. See the webrev#03:
> http://cr.openjdk.java.net/~lucy/webrevs/8233787.03/
>
> I ran the initial webrev iteration through dev-submit and had it active SAP-internally. The current webrev is active since last night SAP-internally. All builds are green. The test show only unrelated issues (some JIT compiler asserts). Of course I will run the final webrev through dev-submit.
>
> Re test coverage: we do not cover 32-bit platforms. And we do not have zero or minimal builds.
Looks good.
More information about the hotspot-dev
mailing list