RFR: 8234741: enhance os::get_core_path on macOS

Baesken, Matthias matthias.baesken at sap.com
Tue Nov 26 08:36:51 UTC 2019


OK I'll do a separate change .

Are you fine with the rest of the patch ?

Best regards, Matthias



> 
> On 25/11/2019 11:44 pm, Baesken, Matthias wrote:
> > Hello,
> >
> > Currently the macOS implementation of os::get_core_path just displays
> the default core file location.
> > However it does not handle/show other locations set by the sysctl
> parameter "kern.corefile" . This is enhanced by this change .
> > I also take care of  handling %P  which is used a lot for  the  pid-placeholder
> on macOS in the  "kern.corefile"  parameter .
> >
> >
> > ( additionally  the change  contains a one-liner adjustment in
> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h  to be able
> to compile  again  on older macOs versions)
> 
> That issue is being discussed elsewhere by the client folk and should
> not be part of this change.
> 
> David
> 
> >
> > Bug / webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8234741
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8234741.0/
> >
> > Thanks, Matthias
> >


More information about the hotspot-dev mailing list