RFR: 8234796: Refactor Handshake::execute to take a HandshakeOperation

[David Holmes]

Hi Robbin,

On 28/11/2019 1:25 am, Robbin Ehn wrote:
> Hi all, please review.
> 
> Here is the result after Per's suggestion:
> http://cr.openjdk.java.net/~rehn/8234796/v2/full/webrev/index.html
> (incremental made no sense)
> 
> Due to circular dependency between thread.hpp and handshake.hpp, I moved 
> the ThreadClosure to iterator.hpp, as was suggested offline.

That all looks good to me! Thanks for splitting these up.

Thanks,
David
-----

> Passes t1-3
> 
> Thanks, Robbin
> 
> On 11/26/19 2:07 PM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8234796
>> Code:
>> http://cr.openjdk.java.net/~rehn/8234796/full/webrev/
>>
>> The handshake code needs more information about the handshake operation.
>> We change type from ThreadClosure to HandshakeOperation in 
>> Handshake::execute.
>> This enables us to add more details to the HandshakeOperation as 
>> needed going forward.
>>
>> Tested t1 and t1-3 together with the logging improvements in 8234742.
>>
>> It was requested that "HandshakeOperation()" would take the name 
>> instead having "virtual const char* name();". Which is in this patch.
>>
>> Thanks, Robbin