RFR: 8231671: Fix copyright headers in hotspot (missing comma after year)

Thomas Schatzl thomas.schatzl at oracle.com
Tue Oct 1 12:46:07 UTC 2019


hi,

On 01.10.19 14:45, Leo Korinth wrote:
> On 01/10/2019 13:28, Thomas Schatzl wrote:
>> Hi,
>>
>> On 01.10.19 13:23, Leo Korinth wrote:
>>> Hi,
>>>
>>> Please review these fixes to copyright headers (comma is added).
>>>
>>> This is tiresome. I have asked Yoshiki Sato to file a fix for jcheck, 
>>> so that we do not have to do this in the future.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~lkorinth/8231671/00
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8231671
>>>
>>> Testing:
>>> None.
>>
>> Can you run the scripts mentioned in 
>> https://bugs.openjdk.java.net/browse/JDK-8231660?
> 
> Hi!
> 
> The script is showing too many false positives, so I will not run the 
> script on all files. My changes does pass though, sorry for not 
> mentioning it.
> 
> git log --name-only --pretty=oneline HEAD~..HEAD | tail -n+2 | xargs 
> bash make/scripts/lic_check.sh -gpl
> 
> (all five files do pass)
> 
> Is that enough?
> 

   ship it :) And I agree with David about triviality.

Thomas


More information about the hotspot-dev mailing list