RFR: 8231671: Fix copyright headers in hotspot (missing comma after year)

Leo Korinth leo.korinth at oracle.com
Tue Oct 1 13:31:42 UTC 2019


On 01/10/2019 13:35, David Holmes wrote:
> Hi Leo,
> 
> Looks good and trivial.


Thank you for your review!

> 
> I'm somewhat surprised these didn't get picked up in earlier copyright 
> checks that were done. :(

I believe the script does not really work as intended (without really 
looking at it). I /guess/ Yoshiki Sato is doing manual work. Someone who 
knows the real requirement should fix the script and make it work for 
every push. I asked Yoshiki Sato who usually creates these bug reports 
to fix jcheck so that we get rid of this. I also told him not to create 
multiple bug reports (I merged three to ease review pain).

Thanks,
Leo

> 
> Thanks,
> David
> 
> On 1/10/2019 9:23 pm, Leo Korinth wrote:
>> Hi,
>>
>> Please review these fixes to copyright headers (comma is added).
>>
>> This is tiresome. I have asked Yoshiki Sato to file a fix for jcheck, 
>> so that we do not have to do this in the future.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~lkorinth/8231671/00
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8231671
>>
>> Testing:
>> None.
>>
>> Thanks,
>> Leo


More information about the hotspot-dev mailing list