RFR: 8230957: [TESTBUG] containers/docker/TestJcmdWithSideCar.java sporadic failures

[Bob Vandette]

I don’t think it’s necessary to state the obvious here:

59     private static final long TIME_TO_WAIT_FOR_MAIN_METHOD_START = 50 * 1000; // milliseconds; increase 5 to 50

Where does this -999 come from?  Is this documented anywhere?  If so please define a constant.  Would this
work with podman?

 237             int pev = -999;

Could you give this a more descriptive name (retryCount maybe)?

238             int rt = 3;


Bob.


> On Oct 8, 2019, at 7:16 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> 
> Hello, please review the following test related change .
>  
> The test containers/docker/TestJcmdWithSideCar.java has been reactivated after
> 
> https://bugs.openjdk.java.net/browse/JDK-8228960
> 
> and we see now sporadic failures.
> 
> We needed to increase/adjust the timeouts and also check the Xmx setting going into the java calls in the docker containers (we might inherit when from the test java opts).
> Also a bit more output has been added to the tests to better understand potential issues .
>  
>  
> Bug/webrev :
>  
> https://bugs.openjdk.java.net/browse/JDK-8230957
>  
> http://cr.openjdk.java.net/~mbaesken/webrevs/8230957.1/
>  
>  
> Thanks, Matthias