RFR [XS]: 8232052: use string literal for format string when handling PauseAtStartupFile

[Baesken, Matthias]

Hi Christoph, thanks for the review .

Will push it as XS tomorrow in case of no objections .

Best regards, Matthias


> -----Original Message-----
> From: Langer, Christoph <christoph.langer at sap.com>
> Sent: Mittwoch, 9. Oktober 2019 14:34
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR [XS]: 8232052: use string literal for format string when
> handling PauseAtStartupFile
> 
> Hi Matthias,
> 
> this seems fine and trivial. +1
> 
> Cheers
> Christoph
> 
> > -----Original Message-----
> > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf
> Of
> > Baesken, Matthias
> > Sent: Mittwoch, 9. Oktober 2019 14:20
> > To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: RFR [XS]: 8232052: use string literal for format string when handling
> > PauseAtStartupFile
> >
> > Hello,  please review the following change .
> >
> > Currently only on Linux (os_linux.cpp) the format string is a string literal and
> > not a variable when handling the PauseAtStartupFile flag.
> > This was done on Linux with
> > https://bugs.openjdk.java.net/browse/JDK-8042894
> > when handling gcc warnings / warning related pragmas; however on the
> > other platforms it is recommended to do the same.
> >
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8232052
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8232052.0/
> >
> >
> > Thanks, Matthias