RFR [XS]: 8233013: deallocate memory after using NEW_C_HEAP_ARRAY

[Baesken, Matthias]

Hello, please review this small  change . It adds  some missing  FREE_C_HEAP_ARRAY  calls  to os::init_system_properties_values   .

bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8233013
http://cr.openjdk.java.net/~mbaesken/webrevs/8233013.1/

(but in case you think we do not need the freeing because of the calls are followed  by   " vm_exit_during_initialization"   calls,
then probably the already in-place freeing before those calls  could be removed  too  for consistency see

http://cr.openjdk.java.net/~mbaesken/webrevs/8233013.1/src/hotspot/os/solaris/os_solaris.cpp.frames.html

lines 456 / 466)



Additionally I was unsure where the freeing of "char* s" from ...

src/hotspot/share/compiler/directivesParser.cpp , line 313

    case JSON_STRING:
      if (option_key->flag_type != ccstrFlag && option_key->flag_type != ccstrlistFlag) {
         . . .
      } else {
        char* s = NEW_C_HEAP_ARRAY(char, v->str.length+1,  mtCompiler);
       strncpy(s, v->str.start, v->str.length + 1);
        s[v->str.length] = '\0';
        (set->*test)((void *)&s);
      }
      break;

occurs, maybe someone can tell ?


Thanks, Matthias