RFR: 8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector
Kim Barrett
kim.barrett at oracle.com
Mon Oct 28 20:34:57 UTC 2019
> On Oct 28, 2019, at 12:30 PM, Leo Korinth <leo.korinth at oracle.com> wrote:
>
> On 24/10/2019 23:16, Thomas Schatzl wrote:
>> Other minor removals that could be done here:
>> - GCStats::kind() / GCStats::Name enum / GCStats::average_promoted_in_bytes() / GCStats::padded_average_promoted_in_bytes() are unused.
>
> Thanks, removed.
With these removals, GCStats seems pretty vacuous. Maybe another
followup to look at further cleanup there?
> I also saw (unrelated to this CMS removal) that TLABStats probably should be obsoleted/removed (it is deprecated now, but in practice obsoleted), should I file a bug for that?
Yes.
> Also unrelated to this CMS removal, should I file a bug for obsolete/removal of PrintGC/PrintGCDetails (deprecated now), or do we want to keep it deprecated?
Don't forget -Xloggc. I don't have an informed opinion as to whether
it's time to remove them. One would want some idea of how prevelent
these formerly very widely used options still are. (For reference, the
change that added them back as deprecated options (after having been
removed by the conversion of GC to use UL) was JDK-8145180. See also
JDK-8170636.) I guess it doesn’t hurt to have the RFE, even if we
decide not to act on it immediately.
> Fixes after suggestions from Kim and Thomas:
>
> http://cr.openjdk.java.net/~lkorinth/8232365/01_02/ (incremental)
> http://cr.openjdk.java.net/~lkorinth/8232365/02/ (full)
Looks good.
More information about the hotspot-dev
mailing list