14 RFR (XXS): 8233137: runtime/ErrorHandling/VeryEarlyAssertTest.java fails after 8232080

[Mandy Chung]

Looks good.

Mandy

On 10/29/19 12:43 PM, mark.reinhold at oracle.com wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8233137
>
> My earlier changes to vmError.cpp didn’t sufficiently guard against the
> vendor VM bug URL string being undefined (oops).  This was revealed by
> fastdebug testing in the main-line CI.
>
> Thanks,
> - Mark
>
>
> diff --git a/src/hotspot/share/utilities/vmError.cpp b/src/hotspot/share/utilities/vmError.cpp
> --- a/src/hotspot/share/utilities/vmError.cpp
> +++ b/src/hotspot/share/utilities/vmError.cpp
> @@ -128,12 +128,14 @@
>   
>   static void print_bug_submit_message(outputStream *out, Thread *thread) {
>     if (out == NULL) return;
> -  out->print_raw_cr("# If you would like to submit a bug report, please visit:");
> -  out->print_raw   ("#   ");
>     const char *url = Arguments::java_vendor_url_bug();
>     if (url == NULL || *url == '\0')
>       url = JDK_Version::runtime_vendor_vm_bug_url();
> -  out->print_raw_cr(url);
> +  if (url != NULL && *url != '\0') {
> +    out->print_raw_cr("# If you would like to submit a bug report, please visit:");
> +    out->print_raw   ("#   ");
> +    out->print_raw_cr(url);
> +  }
>     // If the crash is in native code, encourage user to submit a bug to the
>     // provider of that code.
>     if (thread && thread->is_Java_thread() &&