RFR: 8227168: Cleanup usage of NEW_C_HEAP_ARRAY

Thomas Schatzl thomas.schatzl at oracle.com
Mon Sep 2 13:21:13 UTC 2019


Hi,

On Mon, 2019-09-02 at 14:23 +0200, Leo Korinth wrote:
> Hi!
> 
> After I got caught doing an unnecessary check on the return value of 
> NEW_C_HEAP_ARRAY (a mistake that I copied) I thought it would be good
> to do a cleanup in the sources so that others would not fall into
> this trap. This is the result.
> 
> I have removed some places where the VM will be shut down after 
> NEW_C_HEAP_ARRAY returns NULL (it never does return NULL, it does 
> instead exit). I have also removed lots of unnecessary casts, that
> might hide bugs.
> 
> 
[...]
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8227168
> 
> Webrev:
> http://cr.openjdk.java.net/~lkorinth/8227168/
> 
> Testing:
> mach5 tier1-3 (solaris, linux, windows, mac)

  looks good. Thanks.

Thomas




More information about the hotspot-dev mailing list