RFR: 8230564: Remove os_ext.hpp

David Holmes david.holmes at oracle.com
Wed Sep 4 13:05:30 UTC 2019


Hi Stefan,

On 4/09/2019 9:23 pm, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this patch to remove os_ext.hpp.
> 
> https://cr.openjdk.java.net/~stefank/8230564/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8230564
> 
> Oracle doesn't need this file anymore. Is anyone else replacing this 
> with their own version, or can we simply remove it?

The removal of os_ext.hpp is fine assuming it is not needed.

I don't see the reason for the change in vm_version.hpp. In its usual 
weird way that comment is actually describing the use of 
VM_Version::initialize() rather than Abstract_VM_Version::initialize().

Thanks,
David

> Thanks,
> StefanK


More information about the hotspot-dev mailing list