RFR(S): 8230422: Convert uninterruptible os::sleep calls to os::naked_short_sleep

David Holmes david.holmes at oracle.com
Fri Sep 6 12:42:28 UTC 2019


On 6/09/2019 9:16 pm, Aleksey Shipilev wrote:
> On 9/4/19 11:39 AM, David Holmes wrote:
>> I'd appreciate it if someone involved with Shenandoah can check the one change in that code.
> 
> src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp:
> -    os::sleep(Thread::current(), cur, true);
> +    os::sleep(JavaThread::current(), cur);
> 
> Since os::sleep keeps participating in safepoints ("interruptible = true") after this change, this
> is fine.

Thanks Aleksey! My only concern here was whether the code was obviously 
always executed by a JavaThread (even though the interruptible=true 
implies that).

Cheers,
David



More information about the hotspot-dev mailing list