RFR: 8229202 - Docker reporting causes secondary crashes in error handling

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Tue Sep 10 22:00:14 UTC 2019


+1

On 9/10/19 2:03 PM, Harold Seigel wrote:
> Looks good.
>
> Thanks, Harold
>
> On 9/10/2019 4:44 PM, Bob Vandette wrote:
>> Please review this fix for a secondary failure occurring during 
>> hotspot error reporting.
>> If hotspot encounters a failure in the early VM initialization, the 
>> container initialization
>> will not have been completed causing an assert in the 
>> is_containerized function.
>>
>> The proposed fix will cause the error reporting to not list any 
>> container configuration data
>> since _is_containerized defaults to false.
>>
>>
>> BUG:
>> https://bugs.openjdk.java.net/browse/JDK-8229202
>>
>> PROPOSED FIX:
>>
>> diff --git a/src/hotspot/os/linux/osContainer_linux.hpp 
>> b/src/hotspot/os/linux/osContainer_linux.hpp
>> --- a/src/hotspot/os/linux/osContainer_linux.hpp
>> +++ b/src/hotspot/os/linux/osContainer_linux.hpp
>> @@ -62,7 +62,6 @@
>>   };
>>     inline bool OSContainer::is_containerized() {
>> -  assert(_is_initialized, "OSContainer not initialized");
>>     return _is_containerized;
>>   }
>>
>> Bob.
>>


More information about the hotspot-dev mailing list